fix(ios-stickers): inherit DEVELOPMENT_TEAM from main app target#303
Open
fix(ios-stickers): inherit DEVELOPMENT_TEAM from main app target#303
Conversation
The sticker pack extension target was created without setting DEVELOPMENT_TEAM, requiring developers to manually select the team in Xcode after every prebuild. This follows the same pattern used by expo-share-intent and Expo's own DevelopmentTeam utilities: read the team from the main app target's build configurations and apply it to the extension's build settings and TargetAttributes. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The sticker pack extension target is created without
DEVELOPMENT_TEAM, which means developers have to manually select the development team in Xcode after everynpx expo prebuild. This is easy to forget and causes confusing code signing errors.This PR reads
DEVELOPMENT_TEAMfrom the main app target's build configurations and applies it to the sticker extension target — both in the build settings (XCBuildConfiguration) and in the project-levelTargetAttributes. This matches the pattern used by:expo-share-intent— reads main target'sDEVELOPMENT_TEAMand applies to share extension@expo/config-pluginsDevelopmentTeammodule — applies team to all targetsChanges
getMainTargetDevelopmentTeam()helper that readsDEVELOPMENT_TEAMfrom the main app target's build configurations (filtering out Extension/Widget/Sticker targets)DEVELOPMENT_TEAMincommonBuildSettingswhen availableDevelopmentTeaminTargetAttributeswhen availableTest plan
yarn test)yarn build)npx expo prebuild --clean, the sticker extension target should have the correct development team without manual Xcode intervention🤖 Generated with Claude Code